Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix abbr --add option typo #13

Merged
merged 2 commits into from
Feb 28, 2021
Merged

fix abbr --add option typo #13

merged 2 commits into from
Feb 28, 2021

Conversation

zhylmzr
Copy link
Contributor

@zhylmzr zhylmzr commented Feb 28, 2021

Description

If you use the "--add" option to add abbreviations, the list will not be updated.

Notes

https://fishshell.com/docs/current/cmds/abbr.html?highlight=abbr%20add

@zhylmzr
Copy link
Contributor Author

zhylmzr commented Feb 28, 2021

This fishtape no longer supports "setup" and "teardown", if you need to execute a command, just write the script directly.

jorgebucaran/fishtape#53

@zhylmzr
Copy link
Contributor Author

zhylmzr commented Feb 28, 2021

Maybe we can perform variable cleanup in each unit test to ensure that other tests will not be affected.

@gazorby
Copy link
Owner

gazorby commented Feb 28, 2021

Thank you @zhylmzr, looks good to me!

@gazorby gazorby merged commit 7ae7f7c into gazorby:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhylmzr @gazorby